Entry for 1942 missing in conv_win.sh?

Avatario34 commented 11 months ago

Hello,

super cool project, thanks for making it!

Have just realised that the following line seems to be missing in conv_win.sh for 1942:

python ./romconv.py _1942_rom_cpu1 ../roms/srb-03.m3 ../roms/srb-04.m4 ../galagino/1942_rom1.h

Thanks again, Christian

harbaum commented 11 months ago

Thanks for reporting. I don't use the windows scripts myself. Feel free to submit a pull request.

witnessmenow commented 11 months ago

Could we think of a way of combing these files rather than maintaining two? They are the same other than adding "python" at the front.

A couple of suggestions:

update conv.sh to have "python" at the start. One challenge I could see is maybe people use "python3" for their python install
similar to above, but have a command line argument for the conv.sh file that could that sets the "python" part. You probably wouldn't need to pass in anything on Mac and Unix. This could possibly also allow people to pass in full paths to specific versions of python.
port the script to python itself. Least favourite option for me cause it makes the script more complicated, but possibly simplifies running it.

harbaum / galagino