harbby / sylph

Stream computing platform for bigdata
https://harbby.github.io/project/sylph/index.html
Apache License 2.0
404 stars 173 forks source link

Add unit tests for ideal.sylph.parser.antlr.tree.StringLiteral and ParquetUtil #113

Closed EricHetti closed 5 years ago

EricHetti commented 5 years ago

I've analysed your codebase and noticed that ideal.sylph.parser.antlr.tree.StringLiteral and ParquetUtil is not fully tested. I've written some tests for the methods in this class with the help of Diffblue Cover.

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

harbby commented 5 years ago

Very good