search

harbecke / HexHex

AlphaGo Zero adaptation for Hex
GNU General Public License v3.0
20 stars 4 forks source link

issue with temperature in evaluate_two_models #5

Closed harbecke closed 5 years ago

harbecke commented 5 years ago

evaluate_two_models should give sweep-scores if temperature=0, because there is no noise and thus every move is deterministic

PascalCremer commented 5 years ago

Do you mean every match should end up the same but in fact it doesn't?

harbecke commented 5 years ago

exactly

harbecke commented 5 years ago

https://docs.python.org/3/library/configparser.html#fallback-values the arguments of the configparser only provide fallback-values. if a default value is specified, as for example in the creation of MultiHexGame, this default value overrides the argument.

what a shitshow

harbecke commented 5 years ago

ok this wasn't the problem :laughing: it seems that getfloat is necessary in this case

harbecke commented 5 years ago

there was no assignment of values in play_games of evaluate_two_models, just a list of arguments. thus the temperature value was given to noise_level. fixed with commit 9ad053f331bbf9e7ff8a56bd84e75c2c23169cf2