If a stage has no family dccs, e.g., limbo, the dccs-hook returns an empty selection which causes an error for Evaluate(). It should instead return the original selection.
The dccs- and nondccs-hooks can become desynced. R2API.Director ensures that all stages use the new api, but if someone sets the dccs pool to null, the nondccs hook will be consumed on the next stage, but the dccs on the stage after that. Both hooks/patches should be applied and unapplied from the same method to avoid this.
The nondccs-hook is insufficient to ensure family events with the old api. On top of ensuring the family event chance is 100%, it also requires the family categories to lift their stage restrictions.
The only loophole left is a dccs pool existing but not yielding any family events, e.g., limbo with the default R2API pool and a modder assigning the family events with the old api, or someone removing the family events from, for example, golemplains. In that case the command won't fall back to finding a family from the old api. I think this is fine because as long as a pool exists, it should only use that. And if someone intentionally removes the family events and wants to test the result, they will be very surprised if an event still occurs due to a fallback mechanism.
Evaluate(). It should instead return the original selection.The only loophole left is a dccs pool existing but not yielding any family events, e.g., limbo with the default R2API pool and a modder assigning the family events with the old api, or someone removing the family events from, for example, golemplains. In that case the command won't fall back to finding a family from the old api. I think this is fine because as long as a pool exists, it should only use that. And if someone intentionally removes the family events and wants to test the result, they will be very surprised if an event still occurs due to a fallback mechanism.