harbour / core

Portable, xBase compatible programming language and environment
https://harbour.github.io/
Other
324 stars 207 forks source link

Patch 1 #338

Closed EMG60 closed 1 year ago

EMG60 commented 1 year ago

Fixed libcurl 64-bit name

rjopek commented 1 year ago

To avoid potential compatibility issues, it is important to clearly specify the required dependency versions in your project documentation or user manuals. It is good practice to ensure flexibility and support for different configurations. This can be achieved by customizing your build or configuration scripts to be able to detect and act on the available version of libcurl as needed.

EMG60 commented 1 year ago

The only thing I have fixed is the wrong name of the curl lib name from libcurl-4.dll to libcurl-x64.dll. I don't understand your objection, sorry. Can you clarify?

mlacecilia commented 1 year ago

Hi Enrico, libcurl-4.dll and libcurl.dll are valid names in previous curl versions. Using only libcurl-x64.dll will inhibit the build of them. Rafal is correctly suggesting to preserve backward compatibility in hbp file for previous versions. Best regards.

Maurizio

Il Ven 10 Nov 2023, 15:15 Enrico Maria Giordano @.***> ha scritto:

The only thing I have fixed is the wrong name of the curl lib name from libcurl-4.dll to libcurl-x64.dll. I don't understand your objection, sorry. Can you clarify?

— Reply to this email directly, view it on GitHub https://github.com/harbour/core/pull/338#issuecomment-1805818424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATLNKXXU22TTJNFSHFQH7TYDYZGVAVCNFSM6AAAAAA7GBRU3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVHAYTQNBSGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

EMG60 commented 1 year ago

Ah, ok, I did not know. Done.

EMG60 commented 1 year ago

Anyway, please note that I had removed only libcurl-4.dll, not libcurl.dll. And I didn't find any curl package containing libcurl-4.dll. But you said that it exists so I trust you.

EMG60 commented 1 year ago

Somebody could commit this change, please?