harbur / captain

Captain - Convert your Git workflow to Docker :whale: containers
MIT License
766 stars 51 forks source link

Invalid tag format? #63

Closed callmeradical closed 5 years ago

callmeradical commented 7 years ago

During tagging after a build xxxxxxxxxxxxx.dkr.ecr.us-west-2.amazonaws.com/ss:tags.1.0.1^0 <- no idea how this got there API error (500): {"message":"invalid tag format"}

callmeradical commented 7 years ago

I was able to reproduce this by creating a new repo

$ git init
$ touch README.md
$ git add README.md
$ git commit -am 'Testing'
$ git tag -a 1.0.0
$ captain build

When you issue the command that captain is looking at for branches
```bash
$git name-rev --name-only HEAD

You get

tags/1.0.0^0

Seems unusual, but I added a small fix to get rid of this. Seems to work fine.

Jotschi commented 6 years ago

I just encountered the same error. Is that already fixed?

The issue also happens when using captain 1.1.2 - I'm running the build on debian stretch. git-core: 1:2.11.0-3+deb9u2

berni2288 commented 6 years ago

Same error here.

dkapanidis commented 5 years ago

fixed by #84 and released on v1.1.3