search

hardbyte / ha-evnex

A cloud-polling Home Assistant component to integrate with an Evnex Charger
MIT License
10 stars 1 forks source link

Migrate to v3 sessions #14

Closed drc38 closed 1 year ago

drc38 commented 1 year ago

Looks like I may different linting settings to you? Let me know what to set in vscode if needed.

hardbyte commented 1 year ago

Looks like I may different linting settings to you? Let me know what to set in vscode if needed.

No worries, let's just use an opinionated linter like black. You should be able to configure vscode to be compatible with black, or use it directly.

I'll also get the CI to run it (which admittedly can be annoying). Thanks for the updates

hardbyte commented 1 year ago

Hey @drc38 it would be great when making changes to start from the main branch - otherwise it takes a bit of effort to resolve the conflicts and can mistakenly drop desired changes.

I'll recreate these changes in a new branch directly on main and tag you.

drc38 commented 1 year ago

Yeah sorry, not sure what happened. I thought I was working on a branch of my forked repo rather than directly on your repo.