Fix ASCReader Crash on "Start of Measurement" Line

hardbyte / python-can

The can package provides controller area network support for Python developers

https://python-can.readthedocs.io

GNU Lesser General Public License v3.0

1.3k stars 604 forks source link

Fix ASCReader Crash on "Start of Measurement" Line #1811

Closed RitheeshBaradwaj closed 3 months ago

RitheeshBaradwaj commented 4 months ago

Summary

This PR addresses an issue where the ASCReader crashes when encountering the line 0.000000 CANFD Start of measurement in ASC log files. This line is a combination of two different conventions and should not contain the "CANFD" flag.

Changes

Added logic in the __iter__ method of ASCReader to skip lines matching the regex pattern for "Start of measurement".
This ensures that such special indicator lines are handled separately and do not cause parsing errors.

Fixes #1786.

RitheeshBaradwaj commented 4 months ago

@hardbyte I am unable to merge the PR. Could you please merge it?