hardbyte / python-can

The can package provides controller area network support for Python developers
https://python-can.readthedocs.io
GNU Lesser General Public License v3.0
1.29k stars 602 forks source link

PCAN doesn't exit cleanly #26

Closed hardbyte closed 8 years ago

hardbyte commented 9 years ago

Originally reported by: Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev)


On 2.7 the PCAN interface doesn't release the net it creates. Should have a method in pcan.py that looks like this:

def shutdown(self):
    self.m_objPCANBasic.Uninitialize(self.m_PcanHandle)

hardbyte commented 9 years ago

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Oh that is exciting, its great to hear where the library is being used. I drove a Model S for the first time on Sunday and loved it.

hardbyte commented 9 years ago

Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):


Very belatedly - thanks! This was my first open source contribution, so I appreciate your patience. FWIW I'm hoping to use your library for some automated testing at Tesla, should be pretty cool.

hardbyte commented 9 years ago

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Sure, you should be able to do the fork + PR reasonably easily but if you run into trouble post back here and I'll give you access to this repository. As with github though, usually you would make a few pull requests before given direct access.

Bitbucket has a nice tutorial: https://confluence.atlassian.com/display/BITBUCKET/Fork+a+Repo,+Compare+Code,+and+Create+a+Pull+Request

hardbyte commented 9 years ago

Original comment by Jack Weinstein (Bitbucket: jacklev, GitHub: jacklev):


Brian, gladly - I'm not having success pushing from SourceTree though. Could you give me the necessary access to start a new branch and pull request? Or link me to an explanation of the workflow I should use (I'm new to using Bitbucket :)).

hardbyte commented 9 years ago

Original comment by Brian Thorne (Bitbucket: hardbyte, GitHub: hardbyte):


Would you like to create a pull request for this change Jack? I don't have access to PCAN hardware so hopefully someone else can test/review.