search

hardchor / timesheets

Time tracking done right
http://burgiblog.com/timesheets/
MIT License
98 stars 22 forks source link

Store isn't being hot-reloaded #207

Open hardchor opened 8 years ago

hardchor commented 8 years ago

See https://github.com/hardchor/electron-redux/issues/8:

at my app I have implemented my store as in timesheets, but when I change code during development, it does hot reload, but state does not get updated (when using aliased actions). Does this actually work at the timesheets app ?

const rootReducer = getRootReducer(scope);

but next rootReducer is called like this:

store.replaceReducer(require('../reducers'));

This might be due to https://github.com/hardchor/timesheets/blob/4ccaf08dee4e1a02850b5bf36e37c537fef7d710/app/shared/store/configureStore.js#L66 not being hit (!process.env.NODE_ENV was probably meant to be something like process.env.NODE_ENV !== 'production')

/cc @rsaccon