search

hardcodet / wpf-notifyicon

NotifyIcon (aka system tray icon or taskbar icon) for the WPF platform
MIT License
830 stars 130 forks source link

Migrated the license to MIT #84

Closed Lakritzator closed 1 month ago

Lakritzator commented 2 years ago

Also removed .NET 5.0 support as this is EOL.

Closes #56

Lakritzator commented 2 years ago

Created this for #56

Lakritzator commented 2 years ago

I also bumped up the version to 2.0.x as I consider a license change a potential breaking / major change. Look at this to see how the file header was changed: https://github.com/hardcodet/wpf-notifyicon/pull/84/files#diff-ffd2fa4db00e15fe03e88dff6cc543d6be7000eeb99c57000dbfbdd44e90d889

Lakritzator commented 2 years ago

Oh, forgot, I also changed the namespace to use file scoped namespace. I probably regret that change, not for the change itself but as some PR will no longer merge without manual work. 🙄

I already regretted it, so I undid the change.

trungnt2910 commented 2 years ago

It's been a while, what's the status of this PR? I also see that this branch has conflicts with the base.

Lakritzator commented 2 years ago

Life came in between, just wait.

Lakritzator commented 1 year ago

Hey @punker76 & @hardcodet can you take a look at this, so we can merge it?

tstavropoulos commented 1 year ago

Hey @Lakritzator and @hardcodet

I saw the discussion about this in #56. This is a really great project, and pulling in this license change would definitely make my life easier. Any chance of that happening? Thanks, and good luck!

Linx-ESP commented 8 months ago

Any news?

kjean667 commented 3 months ago

I'm a bit interested in this license change as well due CPOL not being on a corporate's acceptable use list. Are there any stoppers from this being merged? @hardcodet @punker76

punker76 commented 3 months ago

@Lakritzator @hardcodet LGTM

jeroenwalter commented 2 months ago

Hi, any chance that this PR can be added to the main base instead of waiting on a 2.0.0 milestone, that has no clear ETA? I found this fork, https://github.com/HavenDV/H.NotifyIcon , that changed the license to MIT, but I don't think one can just change the license without the express permission of the current maintainers.