hardcore-sushi / DroidFS

Encrypted overlay filesystems implementation for Android. Also available on gitea: https://forge.chapril.org/hardcoresushi/DroidFS
GNU Affero General Public License v3.0
629 stars 41 forks source link

Audio/Video player behavior enhancement #227

Open kedluben opened 1 year ago

kedluben commented 1 year ago

Hi, thank you very much for a great application.

I have few feature requests:

  1. Sliding pictures right/left let me browse images in the folder, but this doesnt work with video and audio files.*
  2. Automaticly play next file in a folder with audio/video files when video/audio file ends.
  3. Video/Audio player doesnt have notification playback control (maybe this is a security feature?)
  4. Multimedia buttons on headphones doesnt work with DroidFS audio/video player.

(I have to close the player, and pick a different file in order to play it)*

Hope you will like some of them, thank you.

hardcore-sushi commented 1 year ago

When you open a file and click "next" (or swipe a picture), a playlist is created with all files of the same type (image/video/audio) in the current and sub-directories. Playlists never mix different file types.

When a video file ends, the next one in the current or sub-directory is played automatically by default. The same applies to audio files. However, audio files are not played after a video file, and vice versa.

Let me know if you encounter any different behavior, or would like this behavior to be configurable.

A notification for the media player could expose title, duration and various other metadata to apps with notification access, or to playback devices if connected via bluetooth.

Control via multimedia buttons could be added to DroidFS. I need to read a bit more about this.

lpapadakos commented 1 year ago

When a video file ends, the next one in the current or sub-directory is played automatically by default. The same applies to audio files. However, audio files are not played after a video file, and vice versa.

Hi @hardcore-sushi I would very much like it if it only played files in the current folder

Specifically, my expectation was that if I have in my folder (sorted by date descending)

subdir/other_a.m4v
subdir/other_b.gif
a.mp4
b.mp4
c.avi
d.gif

and I tap to open b.mp4, tapping next would show me c.avi then d.gif

But it seems that files from subfolders get thown in. For example, I opened a.mp4 and next showed me subdir/other_a.m4v

It seems like it makes a list of all files, subfolders be damned and then playes that by date. Which does seem to match up with what you said

I do love that it respects the sort order (for example, date descending in this case) when pressing next. I'd just like it to stay in the folder

kedluben commented 1 year ago

When you open a file and click "next" (or swipe a picture), a playlist is created with all files of the same type (image/video/audio) in the current and sub-directories. Playlists never mix different file types.

When a video file ends, the next one in the current or sub-directory is played automatically by default. The same applies to audio files. However, audio files are not played after a video file, and vice versa.

Let me know if you encounter any different behavior, or would like this behavior to be configurable.

Right now a cant really test it (because a broke my phone), but I will test next week.

A notification for the media player could expose title, duration and various other metadata to apps with notification access, or to playback devices if connected via bluetooth.

Ok, no problem.

Control via multimedia buttons could be added to DroidFS. I need to read a bit more about this.

That would be great, I will keep this issue open.

Thank you,

hardcore-sushi commented 1 year ago

I would very much like it if it only played files in the current folder

Yes we could add a simple option in the settings for that.

DorianBenjamin commented 1 year ago

When you open a file and click "next" (or swipe a picture), a playlist is created with all files of the same type (image/video/audio) in the current and sub-directories. Playlists never mix different file types.

Could you add an option in the future to change this? As far as i know if i have files in this order "1.webm, 2.mp4, 3.webm" the mp4 file will be skipped, but i argue it shouldn't because its still a video file. It would be awesome to have files such as avi mp4 webm etc. grouped internally. We could open another issue for this if you think this is a reasonable request.

hardcore-sushi commented 1 year ago

@DorianBenjamin It's already the case for me. Playlists are created based on file format (image, video or audio), not on particular file extensions. Do you encounter a different behavior?

DorianBenjamin commented 1 year ago

I thought so. Maybe i got confused by that the sorting wont affect the order which files are played in.

hardcore-sushi commented 1 year ago

It should. The playlist is sorted according to the currently defined sort criteria. If it doesn't, please details the bug.

DorianBenjamin commented 1 year ago

I tested it and it seems to work as it supposed to. Sorry for the false alarm.