(Find) CTRL+F3 difficulty to see buttons

[pribeirojtm]

Hi,

Thanks for the theme, it helps me a lot with the colors and see everything. I want just to point a problem when doing finds in PHPSTORM, that I can't clearly see the buttons "Match Case", "Words" and "Regex".

Do you agree that is an issue? Can you please fix it?

Thanks

[pribeirojtm]

Hi again. Just to add that there are at least other icons that we dont clearly see. E.g. (Close file)

[anson0370]

This does seem a bit problematic. Let me see if there's any way to handle it.

[anson0370]

Can you tell me your PHPStorm version? And have you enabled the New UI?

[anson0370]

The good news is that after more than an hour of searching, I finally found the color attribute key for these buttons and fixed them (thanks to Jetbrains' almost non-existent documentation). The bad news is that I still haven't found how to modify the background color when these buttons are active. I tried to find the answer in the code of the Dracula theme, but I found that they did not modify this background color either.

Anyway, after the Marketplace approves version 0.2.1, you should be able to try it out. Also, you might want to try the New UI.

[pribeirojtm]

I am using PhpStorm v2023.1.2 and I do not have enabled the New UI. Is it required do have the best UI or do you recommend it to be enabled? Still waiting for the new version to test.

[Update] Tested with new UI and when doing CTRL+F3, the problem is gone:

In some cases only, when showing git "annotate", we have the same issue as reported, even in the new UI (Hacker theme). If I use the default Dark theme, the problem does not exists.

[pribeirojtm]

Tested your fix and it fixed the CTRL+F3 part, in the default UI, not the new one. Now I can see those buttons. But, regarding anotate part, it still shows as above. Only when seeing a file with just one commit.

[anson0370]

I have reproduced this issue, give me some time. 😄

[anson0370]

I apologize for not test enough before. I think I have fixed this issue, please wait for version 0.2.2.

Because it's not possible to separately set the foreground color of annotation text for single commit and multiple commits, I had to reduce the brightness of all annotation background colors to ensure good contrast. So it will look slightly different from before.

[pribeirojtm]

Hello @anson0370

I've tested the latests version of your theme in new UI, and the problem in commits area persists:

Using Hard HackerDarker theme in this case. Latests PHPStorm version.

[anson0370]

@pribeirojtm Apologies for the delayed response, I was knocked down by COVID-19 in the past few weeks... I couldn't reproduce your issue successfully under version 0.2.2. Could you provide more detailed information? I tried single commit and multiple commits files under Hard Hacker Darker and NewUI, and everything seems to be working fine.

[pribeirojtm]

Hello @anson0370 . The issue seems fixed. I'm using the new UI and getting used to it, and using your Hard Hacker Darker theme with no issues with colors.

Thanks for the fix. And good to know that you recovered from COVID after being knocked down from it. Stay well

[pribeirojtm]

Closed as fixed