Closed James-S-Santangelo closed 2 years ago
I pushed a couple changes:
gdist
) rather than creating gdist1
and gdist2
and having to ignore one of them. A few bits I have to tidy up, but better to merge now rather than lose momentum.
Thanks so much for the effort here @James-S-Santangelo .
3. At present, this might throw a warning if GDist is
None
sincescikit-allel
can't find it in the VCF, but this doesn't seem to influence downstream processing.
The latest scikit-allel
on PyPI is 1.3.5. However, it returns None
after 1.12.0.
Changed in version 1.12.0: Now returns None if no variants are found in the VCF file or matching the requested region.
So if we install requirements by requirements.txt, genetic_dist
will not be a list full of empty string.
I think this is the reason of #88 and #83.
Hey Nick,
Here is a quick PR with a few minor tweaks:
h5py
module. It was previously trying toimport hdf5
, which does not exist. (mentioned in #49)scikit-allel
. At present, this might throw a warning if GDist isNone
sincescikit-allel
can't find it in the VCF, but this doesn't seem to influence downstream processing.Hope this helps!
James