search

hardisgroupcom / sfdx-hardis

Swiss-army-knife Toolbox for Salesforce. Orchestrates base commands and assist users with interactive wizards to make much more than native sfdx + Allows you to define a complete CI/CD Pipeline and Schedule a daily Metadata backup & monitoring of your orgs
https://sfdx-hardis.cloudity.com
GNU Affero General Public License v3.0
212 stars 40 forks source link

Upgrade to Prettier v3 & prettier-plugin-apex v2 #857

Open Jyleuleu opened 3 weeks ago

Jyleuleu commented 3 weeks ago

Hello,

To resolve Prettier crashes when formatting Apex classes with the latest VSCode version (EINVAL), we have upgraded to Prettier v3.3.3 and prettier-plugin-apex v2.1.5.

Would it be possible to upgrade the versions of Prettier and prettier-plugin-apex used in the quality_check job?"

Thanks

yamioliva commented 1 week ago

Hi @nvuillam,

Just a quick nudge to check if you’ve had a chance to look at issue #857. Jean-Luc posted it a little while back, and we were curious if an upgrade to Prettier v3.3.3 and prettier-plugin-apex v2.1.5 could help with those pesky formatting issues in Apex on the latest VSCode.

No rush at all! Just thought I’d drop a line to keep it on the radar. 😊

Thanks so much!

nvuillam commented 5 days ago

MegaLinter embeds Salesforce Code Analyzer, which embeds PMD, eslint .... not sure about prettier :/

https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview

Anyway, the call to formatters is not blocking when failed ^^