search

hardkernel / linux

Linux kernel source tree
Other
427 stars 408 forks source link

Added a stub ndo_poll_controller to support netconsole - idea from ht… #295

Closed mad-ady closed 7 years ago

mad-ady commented 7 years ago

Idea from https://forum.odroid.com/viewtopic.php?f=82&t=5077

Without this patch, netconsole can't be enabled:

[  187.646648] netpoll: netconsole: local IPv4 address 192.168.228.3
[  187.646671] netpoll: netconsole: interface 'eth0'
[  187.646695] netpoll: netconsole: remote port 6666
[  187.646721] netpoll: netconsole: remote IPv4 address 192.168.228.1
[  187.646745] netpoll: netconsole: remote ethernet address 44:8a:5b:56:37:5a
[  187.646908] netpoll: netconsole: eth0 doesn't support polling, aborting
[  187.652320] netconsole: cleaning up

With the patch, netconsole works fine for XU3/4:

[  184.303266] netpoll: netconsole: local port 6666
[  184.303293] netpoll: netconsole: local IPv4 address 192.168.228.3
[  184.303310] netpoll: netconsole: interface 'eth0'
[  184.303326] netpoll: netconsole: remote port 6666
[  184.303344] netpoll: netconsole: remote IPv4 address 192.168.228.1
[  184.303364] netpoll: netconsole: remote ethernet address 44:8a:5b:56:37:5a
[  184.303705] console [netcon0] enabled
[  184.303719] netconsole: network logging started

I've also left an iperf test running for a night and had no adverse network performance/issues.

mdrjr commented 7 years ago

This should only take effect on XU3, XU4 uses a different network card.

mad-ady commented 7 years ago

Damn, I only tested on an XU3... I'll need to retest, thanks for the tip!

On Mon, May 15, 2017 at 9:08 PM, Mauro Ribeiro notifications@github.com wrote:

Merged #295 https://github.com/hardkernel/linux/pull/295.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hardkernel/linux/pull/295#event-1082761139, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDvKsU2MPum6y8x-LdWSmib7am-ASXzks5r6JSugaJpZM4NZOG4 .