search

hardkernel / linux

Linux kernel source tree
Other
427 stars 408 forks source link

Backport gcc-7 compilation fix from mainline linux tree #300

Closed mk-fg closed 6 years ago

mk-fg commented 7 years ago

Original commit: 474c90156c8dcc2fa815e6716cc9394d7930cb9c Author: Linus Torvalds torvalds@linux-foundation.org Summary: give up on gcc ilog2() constant optimizations

This fixes build issue with gcc-7.

How failure looks: https://sourceforge.net/p/aufs/mailman/message/35865397/ Issue in kernel bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=72785 Link to commit addressing it in mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=474c90156c8dcc2fa815e6716cc9394d7930cb9c

Taijian commented 6 years ago

Could we maybe get this merged, because currently compiling the odroid-3.14.y branch with gcc 7.x breaks hw accelleration on the Odroid C2 as can be seen here.

mk-fg commented 6 years ago

Does recompiling with gcc7 and this patch actually help (as opposed to no-patch or gcc6)?

I'm a bit skeptical, because it's a fix for build error, which afaict affects only aufs module, so if you can build with up-to-date gcc7, doesn't seem to be relevant to your issue and maybe not needed anymore.