hardkernel / linux

Linux kernel source tree
Other
427 stars 408 forks source link

CEC: AOCEC libcec support #372

Closed Ray-future closed 5 years ago

Ray-future commented 5 years ago

This PR makes CEC work with the existing LibCEC AOCEC Adapter. It is basically a short port from the work me and @gdachs did for the 3.14 Kernel. I have not bothered to bring back the legacy CEC input mode which some users like. I'm not sure it's worth it but if I do I will make a seperate PR.

Here are the changes explained.

Tested on Odroid N2 with CoreELEC on Samsung FHD TV and on LG OLED. Works as expected. I know that HK is using a udev rule in ubuntu to symlink the devnode to /dev/aocec so let me know if you want me to drop this change and rebase.

Thanks

mdrjr commented 5 years ago

hi @Raybuntu First thank you for this..

I just have one question before I merge this (as I do prefer to run the libcec version). Is the AOCEC driver merged on upstream libcec or we need to use some downstream patch?

This is for the porpouse of documentation so I can have libcec+kodi working on our Ubuntu image

Ray-future commented 5 years ago

The AOCEC adapter in libcec was merged a long time ago. With the above changes it works ootb with vanilla libcec.

Ray-future commented 5 years ago

But I have not tested it on Ubuntu so you might want to give it a quick test.

mdrjr commented 5 years ago

Hi @Raybuntu I always have to provide our own packages anyway...

I'm merging this :) @Raybuntu As usual thank you so much for your efforts 🥇

Ray-future commented 5 years ago

My pleasure. We (Team CoreELEC) have other changes as we forked the kernel: https://github.com/CoreELEC/linux-amlogic/commits/amlogic-4.9

Some of which are only CE specific but we will upstream as much as possible. We already started to port gxbb over to 4.9 kernel so Odroid C2 might benefit from this more recent kernel too soon.

Thanks R