search

hardkernel / linux

Linux kernel source tree
Other
426 stars 406 forks source link

odroid-6.6.y branch: merge commits bring unnecessary changes #436

Closed kyak closed 3 weeks ago

kyak commented 3 weeks ago

Having a look at odroid-6.6.y branch commits: https://github.com/hardkernel/linux/commits/odroid-6.6.y/ it seems that merge commits on top of Linux 6.6.32 bring a lot of unnecessary changes.

For example, this commit https://github.com/hardkernel/linux/commit/cf4a79fe36c30bb1e2e3932c48f7f74c835acd72 touches 350 files with 3141 additions and 1836 deletions.

These changes touch upon things that are not related to odroid at all - e.g. changes stuff in x86, powerpc or amdgpu subsystems.

This effectively makes it something very different from Linux 6.6.32. It's not really 6.6.32 anymore, but something else.

Can you please clean up the tree only keeping stuff that is really required for odroid? It will simplify review to understand required changes and will help you easier rebase on newer 6.6.y releases.

This must also be done for the sake of correctness. I've built from this branch, but kernel crashes. I'm not eager to report this because there is no way to pinpoint the cause of crash. Is it odroid specific changes? Or is it bogus changes that should not be part of this branch and were simply brought over from previous kernel versions?

kyak commented 3 weeks ago

I think i misunderstood how Github displays merge commits.

After checking it out locally it makes much more sense now.