search

hardkoded / puppeteer-sharp

Headless Chrome .NET API
https://www.puppeteersharp.com
MIT License
3.36k stars 440 forks source link

Fix deserialization exception when retrieving cookie with PartitionKey set #2783

Closed AlexCSDev closed 1 week ago

AlexCSDev commented 1 week ago

At some point CookieParam.PartitionKey became an object in DevTools protocol. This causes deserialization exception because it is currently defined as a string in puppeteer-sharp. This PR implements necessary changes to fix that.

kblok commented 1 week ago

Thanks for jumping in @AlexCSDev. Do you mind matching this change upstream?

AlexCSDev commented 1 week ago

I don't have much experience working with System.Text.Json, but I figured writing JsonConverter for this fix will be a decent solution?

I must mention that I did not test writing as I don't have any way of testing that quickly.