search

hardkoded / puppeteer-sharp

Headless Chrome .NET API
https://www.puppeteersharp.com
MIT License
3.42k stars 446 forks source link

Implement IAsyncDisposable / IDisposable on IBrowserContext #2786

Closed campersau closed 1 month ago

campersau commented 1 month ago

Makes it more convenient to use and aligns with upstream implementation:

https://github.com/puppeteer/puppeteer/blob/3ad2e45c295083de6fc72a5041138c620615b755/packages/puppeteer-core/src/api/BrowserContext.ts#L260-L268

In the second commit I also updated some tests. Looks like this wasn't done upstream so please let me know if I should remove it.