search

hardmaru / WorldModelsExperiments

World Models Experiments
626 stars 172 forks source link

render_mode=False is useless. Fake option not to render #32

Open whoIsTheGingerBreadMan opened 5 years ago

whoIsTheGingerBreadMan commented 5 years ago

render_mode = False means there is 'rgb_array' instead of 'human'. Somehow it still renders.

zacwellmer commented 4 years ago

@whoIsTheGingerBreadMan did you ever fix this?

zacwellmer commented 4 years ago

True and False only determines the render format (rgb_array vs human). Regardless of your choice the environment will still render. Is there a reason why it's necessary to render the environment @hardmaru ?

whoIsTheGingerBreadMan commented 4 years ago

@whoIsTheGingerBreadMan did you ever fix this?

I never fixed this. I think I went down the rabbit hole into the open ai gym code at some point and found that there was some weird thing with one of the dependencies that didn't play well with others... It's been a while...

hardmaru commented 4 years ago

It's been a while since I looked at this, but if I remember correctly, for CarRacing-v0, the environment still "renders" something since it needs to rely on OpenGL to spit out an image that it can resize into a numpy array for the agent's visual inputs. I wished the original env was not based on OpenGL, and rendered directly to numpy, even if it were slower... would have saved me a lot of headaches.