Open mantle2048 opened 2 years ago
Hi !
The function rms_stdev appears many times in the es.py.
rms_stdev
I guess the meaning of this function is to calculate the root mean square (rms) of std (sigma).
Therefore, this function should first calculate the mean and then the square, i.e. np.sqrt(np.mean(sigma*sigma)).
np.sqrt(np.mean(sigma*sigma))
But the implementation is just the opposite in es.py.
Hi !
The function
rms_stdevappears many times in the es.py.I guess the meaning of this function is to calculate the root mean square (rms) of std (sigma).
Therefore, this function should first calculate the mean and then the square, i.e.
np.sqrt(np.mean(sigma*sigma)).But the implementation is just the opposite in es.py.