Hiding window controls on maximized windows with headerbars not working in 20.04

[lekseven]

Control buttons in titlebars are not hidden when windows are maximized.

[wxq851685279]

Same problem

[Hoking007]

Same problem

[Valeryan24]

I don't want to open a new issue because of this and #173 : I have the same bug, but only on Firefox on Ubuntu 20.04, window buttons still visible in maximized state.

But for all other programs - Thunderbird or even those with headerbar - it's OK...

[lekseven]

@Valeryan24 Did you upgrade from 18.04 or do a clean install of 20.04?

[Valeryan24]

Hi, I upgraded from Ubuntu 19.10 on the early stage of development version of 20.04, then did the updates until the final release.

Only today I installed GS extension Unite - before I had many others (now removed) to do the same.

And Firefox is the beta version 76.0b8 from Firefox-Next ppa...

For all other programs tested it works well, only FF I also have the buttons on the Menu bar - enabled (but even if disabled, buttons stay on the tabs bar).

[jonian]

@Valeryan24 If you have disabled titlebar from firefox customize screen, you will have duplicate buttons. The extension cannot remove CSD (client side decorations) buttons from non GTK applications.

When #82 is implemented, you will be able to hide the panel buttons for individual applications.

[jonian]

@lekseven I can't reproduce this issue, can you post the output of cat ~/.config/gtk-3.0/gtk.css and journalctl /usr/bin/gnome-shell | grep unite?

[Valeryan24]

valeryan24@valeryan24-desktop:~$ cat ~/.config/gtk-3.0/gtk.css / UNITE windowDecorations / @import url('/home/valeryan24/.local/share/gnome-shell/extensions/unite@hardpixel.eu/styles/buttons-left/maximized.css'); / windowDecorations UNITE /

valeryan24@valeryan24-desktop:~$ journalctl /usr/bin/gnome-shell | grep unite valeryan24@valeryan24-desktop:~$

Screenshot : https://framapic.org/ooxtgt25TAHw/FjUNNWpRQnbg.png

[jonian]

@Valeryan24, as I said in my previous comment, that is not a bug. It is something that unite can't do.

For client side decorated (CSD) GTK applications, unite uses CSS styles to hide the decorations.

Firefox is not a GTK app, so unite can't hide the decorations. If you don't want to see duplicate window controls, enable "Title Bar" if Firefox customize screen.

[Valeryan24]

@jonian Sorry, I misread and thought the question was for me...

Yes you're right, with Title bar enabled and Firefox restarted, I don't see anymore the buttons and the title bar is well merged on the top panel - perfect, thanks !

[jonian]

@Valeryan24 If you want to make firefox CSD titlebar buttons to hide when maximized you can add in ~/.mozilla/firefox/yourprofile/chrome/userChrome.css:

#main-window[sizemode="maximized"] .titlebar-buttonbox-container  {
  display: none !important;
}

Maybe I will add this in the readme.

[lekseven]

@jonian

$ cat ~/.config/gtk-3.0/gtk.css

@import url('/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/styles/buttons-left.css');

$ journalctl /usr/bin/gnome-shell | grep unite

...
enable@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:52:20
_createButtons@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/windowButtons.js:84:21
_onActivate@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/modules/windowButtons.js:39:10
_runCallback@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:41:17
_activate@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:46:12
_init@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/module.js:19:10
_init@/home/lekseven/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:25:30

[jonian]

@lekseven, you are using an old version. Please update to latest version.