hardpixel / unite-shell

Unite is an extension that makes GNOME Shell look like Ubuntu Unity Shell.
GNU General Public License v3.0
906 stars 61 forks source link

Top bar window buttons appear when all windows closed #302

Closed lbell closed 1 year ago

lbell commented 2 years ago

Describe the bug If all windows are closed, the top bar window buttons magically reappear, even though there is not target to minimize, close, etc.

To Reproduce Steps to reproduce the behavior:

  1. Close all windows
  2. The top bar window buttons appear

Expected behavior There should be no top bar window buttons when all windows are closed.

Environment (please complete the following information):

Other details Only started recently (last update?) was initially working fine on 22.04

Coeur-Noir commented 1 year ago

Hi,

I can see something similar but I think I know why : ⋅ do you make use of DiNG extension for showing icons on desktop ( it's offered by default in Ubuntu 22.04 ) ? ⋅ are you on a Wayland session ( also default in 22.04 ) ?

window_buttons_desktop

Unite Version here is 65 on a regular gnomish Ubuntu 22.04. What I suspect here : under Wayland, DiNG is seen as a maximized window, hence buttons appearing. If I disable DiNG extension, buttons immediately disappear. Or just using Xorg session ( with DiNG enabled ) hence I think it's related to Wayland.

A bit like here : https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons-ng/+bug/1981837 maybe same kind of fix would apply to Unite ( for ignoring DiNG's maximized window ) ?

lbell commented 1 year ago

Bingo. On Waylund and using DiNG. Was not an issue initially, so sounds similar.

Would like to be able to use waylund and DiNG.

So would the fix: check the "window.skip_taskbar" flag and ignore any windows with that set. Then it won't get fooled by DING technically being a maximized window. work for unite?

Thanks!

Coeur-Noir commented 1 year ago

« _So would the fix: check the "window.skiptaskbar" flag and ignore any windows with that set. Then it won't get fooled by DING technically being a maximized window. work for unite? »

I don't know @lbell it's just my assumption, I'm no dev' just a stupid user ;-) It sounds like same « logic ».

Idechix commented 1 year ago

Hi, I'm experiencing the same issue. I'm using a fresh install of Ubuntu 22.04 on Wayland, but without DING installed. In my case the top bar window buttons are visible as soon as the session starts. It shows each time the desktop is visible.

Coeur-Noir commented 1 year ago

Isn't DING installed by default on 22.04 ?

Maybe you turned off icons on desktop but did not really stop the extension.

Here if I turn off DING, buttons no longer appear / only appear when expected.

Le 28 juillet 2022 10:47:27 GMT+02:00, Idechix @.***> a écrit :

Hi, I'm experiencing the same issue. I'm using a fresh install of Ubuntu 22.04 on Wayland, but without DING installed. In my case the top bar window buttons are visible as soon as the session starts. It shows each time the desktop is visible.

-- Reply to this email directly or view it on GitHub: https://github.com/hardpixel/unite-shell/issues/302#issuecomment-1197850158 You are receiving this because you commented.

Message ID: @.***>

Idechix commented 1 year ago

Isn't DING installed by default on 22.04 ? Maybe you turned off icons on desktop but did not really stop the extension. Here if I turn off DING, buttons no longer appear / only appear when expected.

I checked on apt, and the ding package is not installed on my system. Am I wrong?

Idechix commented 1 year ago

I checked on apt, and the ding package is not installed on my system. Am I wrong?

Ok guys, I was stupid... I found the ding extension, and yes it was installed on my desktop by default! Turning it off solved the problem.