search

hardpixel / unite-shell

Unite is an extension that makes GNOME Shell look like Ubuntu Unity Shell.
GNU General Public License v3.0
906 stars 61 forks source link

Gnome 43 #306

Closed zeten30 closed 1 year ago

zeten30 commented 1 year ago

This introduces breaking changes. 'Main.panel.statusArea.appMenu' changed to '.quickSettings'.

Works fine for me, no errors, but it may need some further testing.

https://gjs.guide/extensions/upgrading/gnome-shell-43.html#quick-settings

jonian commented 1 year ago

Hi @zeten30, thanks for the PR. The link you provided says that aggregateMenu is removed not appMenu. Also compatibility with earlier versions should be kept.

zeten30 commented 1 year ago

Hmm. correct. Was there an aggregateMenu before?

I'll update MR. Only metadata.json needs changing

jonian commented 1 year ago

Thanks again for the PR @zeten30! I created a PR #307 for gnome 43 with support for older versions so I will close this. You can check it to see how the extension implements support for older versions and follow the same pattern in your future PRs.