hardpixel / unite-shell

Unite is an extension that makes GNOME Shell look like Ubuntu Unity Shell.
GNU General Public License v3.0
903 stars 61 forks source link

Hide window titlebars doesn't work for tiled windows in Gnome 44 #333

Closed prurigro closed 8 months ago

prurigro commented 1 year ago

Describe the bug

The setting to hide window titlebars works great for maximized apps, and they're always hidden if it's set to Always. If the setting is set to Both or Tiled however, tiling the windows doesn't hide the titlebars.

To Reproduce

  1. Ensure Gnome 44 is installed
  2. Configure Hide window titlebars to either Tiled or Both
  3. Reload the shell (the setting doesn't update on the fly)
  4. Open an app that uses server-side decorations
  5. Tile the app (either side of the screen will do)
  6. The decorations are still present

Expected behavior

The decorations should be hidden while tiled

Environment (please complete the following information):

Logs

Nothing appears to get logged when tiling or maximizing windows.

Additional context

I can provide some if this isn't easily reproduced

medigencedev commented 1 year ago

so to be specific it is not working with GNOME44.2

prurigro commented 1 year ago

Yeah, sorry- I should have specified 44.2 since I can't confirm it wasn't working on previous versions.

mogorman commented 1 year ago

doesn't work on gnome 44.1 on my install.

harpreetsb commented 1 year ago

any update on fix?

phamson02 commented 1 year ago

I tried to follow the fix as in this pull request and it works. I am on Gnome 44.2.

medigencedev commented 1 year ago

now what happens is, when you login back after your screen sleeps, the windows are unmaximized.

jonian commented 11 months ago

This is a mutter issue and probably #324 too. The PR #334 is not the best solution since it has it's own issues. I have reported this upstream.

jonian commented 8 months ago

Gnome has broken backwards compatibility for extensions. This extension now supports only gnome 45.