search

hardpixel / unite-shell

Unite is an extension that makes GNOME Shell look like Ubuntu Unity Shell.
GNU General Public License v3.0
929 stars 62 forks source link

gicon-based buttons to workaround the scaling issue #356

Open ilya-m32 opened 10 months ago

ilya-m32 commented 10 months ago

Needs discussion, not for merging

A workaround for https://github.com/hardpixel/unite-shell/issues/106

It seems that the problem still exist in gnome-shell=45.0 and there's no reaction from the gnome team.

Since the bug is very annoying to me, I decided to take a look if there are any fixes we can do now. I found that if we leverage gicons instead of CSS backgrounds, shell renders icon size correctly after the screen scale changes. It is less convenient than CSS-based styling but works as intended.

For testing purposes, I converted adwaita and ambience themes to gicons in backward-compatible fashion and personally satisfied with this workaround.

@jonian let me know what do you think. I can make a separate independent theme with this fix (for people like me with multi-scale setups) or try to convert other themes to gicons as well.

To all: extra testing could be also useful. I only tested this is gnome 45.0 with these two themes.

ilya-m32 commented 9 months ago

@jonian wdyt if I convert the remaining themes? ​