search

hardpixel / unite-shell

Unite is an extension that makes GNOME Shell look like Ubuntu Unity Shell.
GNU General Public License v3.0
948 stars 62 forks source link

Unite display scaling issue #373

Closed jvanmalder closed 1 month ago

jvanmalder commented 3 months ago

Describe the bug When changing the display scaling setting, the top bar window buttons don't scale along.

To Reproduce Steps to reproduce the behavior:

  1. Go to Gnome Settings, Displays
  2. Change Scale from 100% to 125% for example
  3. The top bar window buttons don't have the correct scaling and look out of place

Expected behavior When changing the display scaling settings, I expect the top bar window buttons to scale along.

Screenshots

Changing from 125% to 100% display scaling causes the following: unite-125-to-100

Changing from 100% to 125% display scaling causes the following: unite-100-to-125

What it's supposed to look like: unite-normal

Environment (please complete the following information):

Logs No relevant logs.

Additional context Usually this isn't annoying, as the display scaling isn't changed a lot. However, this becomes annoying when using a laptop that has an internal screen which uses different scaling than external monitors connected via a docking station. Every time the laptop is docked / undocked, this issue pops up. Currently a workaround can be used by simply disabling and re-enabling the Unite extension after the issue happens.

ilya-m32 commented 2 months ago

Seems to be a duplicate of https://github.com/hardpixel/unite-shell/issues/106

@jvanmalder, This is a bug in gnome shell St and there's no reaction from gnome team so far.

I prepared a workaround proof-of-concept which I use myself: https://github.com/hardpixel/unite-shell/pull/356. I received no reaction/opinion from the plugin maintainer, so I'm keeping it in my forked repo. For me it works well, but no guarantees.

jonian commented 2 months ago

Hi @ilya-m32, apologies for not responding to your PR. I wasn't sure what to respond at the time and then forgot about it :disappointed:.

My main issue with #356 is that it replaces the existing theme. The gicon implementation should be optional and the default should remain the css theme, since it is more efficient.

That way, if the issue is ever resolved by gnome, we can remove the gicon implementation.

ilya-m32 commented 2 months ago

@jonian no worries and thanks for your reply: supporting a non-profit OSS project is understandably hard and I appreciate your work.

I did this as a proof of concept. If you would in principle accept a backwards compatible and optional workaround with gicons, I can rework my PoC accordingly.

I just wanted to make sure we were comfortable with this idea in principle before I would invest my time in it.

jonian commented 2 months ago

@ilya-m32, yes an optional workaround using gicon is fine by me.