nesquena
commented
10 years ago :+1: great work overall Rong! A few notes after checking out the code:
- Nice use of ViewHolder in the adapter!
- Good to see you were able to format the timestamp cleanly
- Nice to see you used a PullToRefresh library for easy timeline refreshes
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being calculated for Compose
- Nice use of jackson to cleanup json deserialization!
- As you mentioned see if you can get offline working. See the persistence guide and this other guide for more details.
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
hi @nesquena, Here's my submission for week 3 homework. User stories implemented: User can sign in using OAuth login flow User can view last 25 tweets from their home timeline User should be able to see the user, body and timestamp for tweet User should be displayed the relative timestamp for a tweet "8m", "7h" User can load more tweets once they reach the bottom of the list using "infinite scroll" pagination User can compose a new tweet User can click a “Compose” icon in the Action Bar on the top right User will have a Compose view opened User can enter a message and hit a button to post to twitter User should be taken back to home timeline with new tweet visible Optional: User can see a counter with total number of characters left for tweet Optional: User can refresh tweets timeline by pulling down to refresh (i.e pull-to-refresh) Optional: Improve the user interface and theme the app to feel twitter branded
Hours: 12 not including doing the video walk through ~15 with review It took a while longer because I'm new to gradle. I also spent a while trying to get the originally suggested pull to refresh library imported as a gradle module. Will keep working on getting the db save working and other optional stories but just wanted to get this in before the deadline. Thanks very much for your feedback! Rong