Upgrade to Debian 10 Buster

hardware commented 5 years ago

:exclamation: Current sticking points

[ ] Zeyple : pygpgme is no longer supported by upstream for years and has a successor (python-gpg), python-gpgme package is no longer available with Buster. Zeyple needs to be updated.
- [X] Zeyple has been temporarily disabled in mailserver 1.1-latest. Open issue : https://github.com/infertux/zeyple/issues/52
- [ ] Temporary solution : Install python-gpgme deb package from debian.pkgs.org.

:information_source: Changes

[X] Dovecot https://wiki2.dovecot.org/Upgrading/2.3
- [X] ssl_protocols has been replaced by ssl_min_protocol.
- [X] Since 2.3.3+ DH parameter usage is optional and can be omitted. Amend ciphers to disallow non-ECC based DH algorithms, new ssl_cipher_list = EECDH+AES:EDH+AES+aRSA:!DH
- [X] ssl_dh_parameters_length removed.
- [X] ssl-parameters.dat file is now obsolete and has been removed.
- [X] Database password can now contain a '#' character.
[X] Postfix Postfix 3.4, Postfix 3.3, Postfix 3.2
- [X] Since Postfix 3.3, the master daemon can be started in the foreground ! Finally :tada: :cake:
[X] clamav-unofficial-sigs
- [X] Yara rules are broken with clamav ≥ 0.100. Yara rules are now disabled in default configuration. Open issue : link

:warning: Warnings

[X] postfix/postfix-script: warning: symlink leaves directory: /etc/postfix/./makedefs.out. Open issue : link (This warning is harmless)

:beetle: Bugs

No bug found yet, only zeyple unit tests fail.

Softwares version

Software	Stretch	Buster
Postfix	3.1.12	3.4.5
Dovecot	2.2.27	2.3.4
Fetchmail	6.3.26	6.4.0
ClamAV	0.100.3	0.101.2
Unbound	1.6.0	1.9.0
Rsyslog	8.24.0	8.1901.0

Upgrade state : Complete

hardware commented 5 years ago

For all volunteers, you can begin to test this new version unless if you are currently using Zeyple. Your feedback will be appreciated.

:building_construction: Builds & tests (CI) :

Travis

neuffer commented 5 years ago

Shouldn't we update Python from Python 2 to Python 3 as well? I think Debian 10 support would be a great place to do it. Are there any parts that still depend on Python 2?

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

hardware commented 5 years ago

@neuffer done.

neuffer commented 5 years ago

Thanks!

dguttierrez commented 5 years ago

Everything is ok after upgrade on my two servers. What if we add zeyple.py into rootfs, can we then use it?

hardware commented 5 years ago

@dguttierrez nope because zeyple.py uses pygpgme and the maintainers of Debian Project dropped the old python-gpgme with pygpgme module inside.

You can install pygpgme with pip directly, it should works, but this package was last released in 2012 (started in 2006) and I don't want to use an unmaintained GPG module, for security reason, in the next image update. Zeyple needs to be updated.

Unmaintained package : https://packages.debian.org/en/stretch/python-gpgme New package : https://packages.debian.org/en/buster/python-gpg

ksylvan commented 5 years ago

I'm seeing this on startup.

mailserver      | 2019-08-12T23:54:19.721747+00:00 mail dovecot: master: Fatal: service(dict) User doesn't exist: vmail (See service dict { unix_listener /var/run/dovecot/dict { user } } setting)
mailserver      | 2019-08-12T23:54:19.739876+00:00 mail root: s6-supervise : spawning unbound process
mailserver      | [1565654059] unbound[1184:0] warning: did not exit gracefully last time (1157)
mailserver      | 2019-08-12T23:54:19.755257+00:00 mail root: s6-supervise : spawning dovecot process
mailserver      | 2019-08-12T23:54:19.764876+00:00 mail root: s6-supervise : spawning rspamd process
mailserver      | 2019-08-12T23:54:19.782181+00:00 mail root: s6-supervise : spawning freshclam process
mailserver      | ./run: line 13: /var/run/clamav/freshclam.pid: No such file or directory
mailserver      | 2019-08-12 23:54:19 #1198(main) <fb8165>; main; detect_priv: user specified does not exists (Success), aborting
mailserver      | 2019-08-12T23:54:19.808271+00:00 mail root: s6-supervise : virus database downloaded, spawning clamd process
mailserver      | ./run: line 4: /var/run/clamav/clamd.pid: No such file or directory

ksylvan commented 5 years ago

Temporarily downgraded to mail-server:1.1-stable for the above problem. Will look into it. Would appreciate any ideas, @hardware

hardware commented 5 years ago

Upload your entire logs please.

ksylvan commented 5 years ago

Upload your entire logs please.

mailserver.log

@hardware

hardware commented 5 years ago

Ok, got it. So the issue is : you've actived Zeyple and the mail server should have stopped right after this warning :

[WARNING] Zeyple support has been temporarily disabled in the master branch following the Debian 10 update. Please, use the stable docker tag (1.1-stable) until the issue fixed. More information here : https://github.com/hardware/mailserver/issues/393

But my exit procedure doesn't works as expected, I forgot about the changes made by @Matchlighter.

Disable Zeyple or stay with 1.1-stable. Zeyple can't work right now with the latest image.

EDIT: fixed in https://github.com/hardware/mailserver/commit/c0c4038c0ecaf8791ea2f7017e7feb4a44595cb1

@ksylvan now your container should stop and force you to switch on 1.1-stable.

ksylvan commented 5 years ago

I actually don't need Zeyple. I can disable it. Thank you.

sknight80 commented 5 years ago

Can I use this version? I can install one of my mail servers.

hardware commented 5 years ago

So far so good, you can use it.

hardware commented 5 years ago

Zeyple' author wants to rewrite his program starting from scratch with Golang : https://github.com/infertux/zeyple/issues/52#issuecomment-431650033

As a temporary solution for Buster, I can install python-gpgme deb package from debian.pkgs.org. This is not ideal but why not.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

hardware / mailserver