search

hardy1334 / ip_proj-

1 stars 1 forks source link

Small Bug in Light and Dark theme #3

Open harshay97 opened 5 years ago

harshay97 commented 5 years ago

I think there is some small bug in light and dark theme,it doesn't change with click eventlistener but with mouseover eventlistener.I guess this thing needs to be changed.

Screenshot from 2019-04-22 16-08-50

harshay97 commented 5 years ago

@hardy1334 can u guide me a bit how to work around it ?

hardy1334 commented 5 years ago

sure, I guess initially u need to be familiar with concept of props in react, just work around it and I guess u will figure it out

harshay97 commented 5 years ago

can you guide me with some help regarding props in react

hardy1334 commented 5 years ago

sure you can go through https://reactjs.org/docs/components-and-props.html to get idea about props

harshay97 commented 5 years ago

Thanks a lot

harshay97 commented 5 years ago

Is the website compatible with other browsers? such as Chrome and Mozila Firefox?

hardy1334 commented 5 years ago

yeah,it works on all browsers, the thing is that there some properties of css which works in chrome and may not work in firefox

harshay97 commented 5 years ago

Okay, I tried to open the same website on a safari browser on a mobile application but seemed to have a totally different layout compared to chrome on an android.

Is this something you would like to fix or is it not a problem?

hardy1334 commented 5 years ago

this project is currently not responsive(that means ) it looks good on all devices whether its ipad,mobile,pc,etc.

If u want u make it responsive and submit pull request,I will review that

harshay97 commented 5 years ago

okay. For the js files within the components folder, will they affect the output of the website (the CSS functionality)

harshay97 commented 5 years ago

Would it be ok if some of the features are changed around the website? or would you like it as it is? I could potentially make it sharper

hardy1334 commented 5 years ago

sure go for it,looking forward for it

harshay97 commented 5 years ago

Ill see if it can be done, otherwise it will stay the way it is