harelba / q

q - Run SQL directly on delimited files and multi-file sqlite databases
http://harelba.github.io/q/
GNU General Public License v3.0
10.15k stars 419 forks source link

Migrate from optparse to argparse #291

Closed InCogNiTo124 closed 2 years ago

InCogNiTo124 commented 2 years ago

closes #290

harelba commented 2 years ago

ignore the mac packaging failure, should be disabled, as brew does not allow for actually testing stuff inside the repo itself (i need to remove it altogether).

InCogNiTo124 commented 2 years ago

If that's the case, I'd say I'm done here :)

harelba commented 2 years ago

Sorry, too many things in parallel. I'll merge it when as soon as I get the chance.

Thanks for the fixes @InCogNiTo124 !

harelba commented 2 years ago

not forgetting this, i'm just a bit sick. will merge when possible

InCogNiTo124 commented 2 years ago

not forgetting this, i'm just a bit sick. will merge when possible

ok, no worries. thank you for the notif. wish you a fast recovery!

harelba commented 2 years ago

finishing up some changes to the master branch, so it will be easy to integrate your PR.

I'll update when done, so you can update your downstream, and then we'll merge

harelba commented 2 years ago

@InCogNiTo124 - I've finished fixing the master branch. Can you please rebase/merge from the master and update the PR, so I can merge this?

InCogNiTo124 commented 2 years ago

Will this merge fix it?

harelba commented 2 years ago

triggered it. Yes, the changes I've made should fix the tests here (the issues were related to the release process, which i've finalised in the master branch).

harelba commented 2 years ago

the prerelease stage failed because it's a pull-request by you and not by me, so there's no permissions.

I'll fix this later, but on the master branch this should be ok.

I'll merge it

harelba commented 2 years ago

i'll check the build process in master and make sure it's ok.

Thanks @InCogNiTo124 for the PR!

InCogNiTo124 commented 2 years ago

Glad I could help, thank you for the tool!