martinhpedersen
commented
4 years ago Simplest solution would probably be to wrap *Modem in a Conn struct and move all the relevant methods to the Conn struct like this:
func (m *Modem) DialURL(...) (net.Conn, error) {
// Here you must dial the connection before returning of course
return &Conn{m}
}
type Conn struct { m *Modem }
func (c *Conn) Read(d []byte) (int, error) {
// Code from Modem.Read()
}
func (c *Conn) Write(d []byte) (int, error) {
// Code from Modem.Write()
}
func (c *Conn) Close() error {
// Here you must ensure that only the connection is closed, not the underlying serial connection to the modem.
}
...Get it?
blockmurder
harenber
Yes, the API is really starting to take shape now :)
I have another suggestion: Maybe you could also add a Conn struct to represent a dialed connection? If you move the net.Conn methods (Read, Write, SetDeadline..., Close...) to that struct, I believe the API would be even cleaner and more idiomatic.
What do you think?
Originally posted by @martinhpedersen in https://github.com/harenber/ptc-go/issues/7#issuecomment-534721940