search

harfbuzz / harfbuzz

HarfBuzz text shaping engine
http://harfbuzz.github.io/
Other
3.69k stars 593 forks source link

[instancer] add a warning for CFF partial instancing #4705

Closed qxliu76 closed 1 month ago

qxliu76 commented 1 month ago

For #4700

behdad commented 1 month ago

CFF1 has no variations so no need there.

On Tue, May 7, 2024, 2:00 PM Qunxin Liu @.***> wrote:

For #4700 https://github.com/harfbuzz/harfbuzz/issues/4700

You can view, comment on, or merge this pull request online at:

https://github.com/harfbuzz/harfbuzz/pull/4705 Commit Summary

File Changes

(2 files https://github.com/harfbuzz/harfbuzz/pull/4705/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/harfbuzz/harfbuzz/pull/4705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABC4KYIE2RQEY52G72BFULZBE6FLAVCNFSM6AAAAABHLXKKD6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DIMRSGM4DEMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

qxliu76 commented 1 month ago

Updated the PR. Thanks!

ebraminio commented 3 weeks ago

Maybe subsetter can raise some similar warning for unsupported AAT layout tables subsetting, or maybe it could suggest adding keep gid flag and keep the layout table if requested, sorry if this is considered already and I'm just unaware of or doesn't worth considering.

behdad commented 3 weeks ago

Feel free to add l send PR.