search

harfbuzz / harfbuzz_rs

A fully safe Rust wrapper for the harfbuzz text shaping library.
MIT License
55 stars 23 forks source link

Update to rusttype 0.5. Use rusttype::Error. #10

Closed jimblandy closed 6 years ago

jimblandy commented 6 years ago

In 0.5.0, the rusttype crate got its own Error type, which covers the same cases harfbuzz_rs's RusttypeFontFuncsError does. Rather than translate rusttype::Error values into RusttypeFontFuncsError values, I took the more intrusive approach of removing RusttypeFontFuncsError, and just re-exporting rusttype::Error as harfbuzz_rs::rusttype::Error. This removes the need to depend on the failure crate.

If you'd rather handle the update by keeping the RusttypeFontFuncsError type and translating rusttype::Error values into those, I'm happy to re-do the changes that way; just let me know.

manuel-rhdt commented 6 years ago

Thank you, looks great! I do prefer to use rust type errors directly, now that they exist. This will be released soon in version 0.2.