search

harfbuzz / harfbuzz_rs

A fully safe Rust wrapper for the harfbuzz text shaping library.
MIT License
55 stars 23 forks source link

UnicodeBuffer::add_str does not allow adding subitems #15

Closed khaledhosny closed 5 years ago

khaledhosny commented 5 years ago

The HarfBuzz C API takes a pointer to text, its length, and start and length of subitem (run) being shaped, and this is important when shaping parts of larger text. The rust API takes only a string, so one can only the part being shaped without the rest of its context (which prevents HarfBuzz from doing things like Arabic shaping across runs of text).

manuel-rhdt commented 5 years ago

Thanks for the issue. I missed that capability of harfbuzz. I will think of how to incorporate adequate changes into the wrapper.

khaledhosny commented 5 years ago

Thanks!