search

harfbuzz / harfbuzzjs

Providing HarfBuzz shaping library for client/server side JavaScript projects
https://harfbuzz.github.io/harfbuzzjs/
Other
204 stars 35 forks source link

Add buffer flags, fix delimiters #31

Closed simoncozens closed 3 years ago

simoncozens commented 3 years ago

This allows setting buffer flags from Javascript. However, when writing it I also noticed that we need a change to hbjs's shape_with_trace. This is because hb_buffer_serialize_glyphs now writes the array delimiters ([]) on JSON output for us, so we do not need to add them ourselves. So even if you don't want the buffer flags fix, you want to merge bf84c11.

behdad commented 3 years ago

LGTM in general. The delimiters change made me remember that we haven't made a HarfBuzz release since August. @khaledhosny any chance you can get one out before the end of the year?

khaledhosny commented 3 years ago

@khaledhosny any chance you can get one out before the end of the year?

I’ll give a try.