Source-Han-Serif subsetting failed

[yisibl]

I use SourceHanSerifCN-Regular in the demo, and the generated size is larger than the original font.

subset.zip

[behdad]

That doesn't mean it failed. Just that it's not as well optimized. Probably because of subroutinization. Adobe contributed the CFF/CFF2 subsetting code; no one left in the project knows that code base, so I can't be sure currently. cc @garretrieger

[yisibl]

hb-subset SourceHanSerifCN-Medium.ttf --text=你好123 --output-file=subset.ttf

hb-subset is ok.

[ebraminio]

So maybe desubroutinize flag is set somehow? We aren't touching it here at least https://github.com/harfbuzz/harfbuzzjs/blob/gh-pages/subset/index.html#L27

[garretrieger]

Do you have a command line which reproduces the problem? I tried:

hb-subset SourceHanSerifCN-Regular.ttf --text=你好123 --output-file=subset.ttf

Which results in a subset of size 2856 bytes.

[garretrieger]

Also that subset.ttf is not a valid font file. How did you produce it?

[garretrieger]

Looks like some sort of bug in the demo. No matter what font I put in it gets a 26 mb download back. Don't think this is related to harfbuzz. Please re-open if you have a reproduction via harfbuzz.

[garretrieger]

Oh sorry, thought this issue was posted in harfbuzz. Re-opening.

[yisibl]

Yes, I dragged and downloaded the font file in the demo, I tried other fonts, and it was always 26MB.

[ebraminio]

@yisibl was a regression on the demo, my fault, Blob needed a concrete buffer to work upon and subarray views weren't enough for it and 26mb was basically whole heap of the wasm machine.

[yisibl]

@ebraminio Thanks for the quick fix.