harfbuzz / harfbuzzjs

Providing HarfBuzz shaping library for client/server side JavaScript projects
https://harfbuzz.github.io/harfbuzzjs/
Other
197 stars 34 forks source link

Add harfbuzz v6 symbols to hb-subset #68

Closed luciancooper closed 1 year ago

luciancooper commented 1 year ago

I believe these symbols (new in harfbuzz v6) should be added to those exported in the hb-subset.symbols file:

hb_subset_input_pin_axis_location hb_subset_input_pin_axis_to_default hb_subset_preprocess

Adding these lines to hb-subset.symbols should do it?

_hb_subset_input_pin_axis_location
_hb_subset_input_pin_axis_to_default
_hb_subset_preprocess
luciancooper commented 1 year ago

Realizing now that these symbols are incompatible with compiling harfbuzz with the -DHB_TINY flag. To make them work this would have to be added to config-override-subset.h:

#undef HB_NO_VAR

In accordance with the README, if this "extends harfbuzzjs in ways that you think others will also benefit from", this can be pursued, otherwise, this issue should be closed?

khaledhosny commented 1 year ago

Yes, this seems like it.

yisibl commented 1 year ago

@luciancooper Do you have plans to submit a PR?