search

harfbuzz / harfbuzzjs

Providing HarfBuzz shaping library for client/server side JavaScript projects
https://harfbuzz.github.io/harfbuzzjs/
Other
197 stars 34 forks source link

Fix: Destroy the right pointer in `collectUnicodes` #77

Closed papandreou closed 1 year ago

papandreou commented 1 year ago

Right now face.collectUnicodes creates a temporary set, but frees the pointer holding the face itself instead of the temporary set at the end -- probably a copy/paste error. This leads to RuntimeError: memory access out of bounds when using the face after that.

papandreou commented 1 year ago

Thanks! Mind doing a patch release with this change? 🤗

behdad commented 1 year ago

I think @khaledhosny can do that.

khaledhosny commented 1 year ago

I think @khaledhosny can do that.

Done

papandreou commented 1 year ago

Thanks a bunch!