search

harfbuzz / rustybuzz

A complete harfbuzz's shaping algorithm port to Rust
MIT License
551 stars 37 forks source link

Clippy fixes #140

Open asibahi opened 4 hours ago

asibahi commented 4 hours ago

The first commit contains a bulk of basic lints (avoiding double refs, needless returns, needless format!, and so on).

The other commits are divided by lint they apply.

RazrFalcon commented 3 hours ago

collapsible if should probably be ignored. We try to match harfbuzz's code style when possible. So the code should look as close to harfbuzz as possible, at least in theory.

alerque commented 3 hours ago

We can configure the lint to be ignored project wide if it is interfering with keeping the cognitive load low when comparing code bases.