harfbuzz / uharfbuzz

A HarfBuzz Python binding
Apache License 2.0
68 stars 25 forks source link

Files missing in 0.24.0 sources #120

Closed alerque closed 2 years ago

alerque commented 2 years ago

I'm not sure if the issue is with this project or upstream, but trying to update Arch packaging for this and building in a clean chroot, I get:

gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto -ffat-lto-objects -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -DHB_NO_MT=1 -DHB_EXPERIMENTAL_API=1 -DHAVE_MMAP=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_MMAN_H=1 -Iharfbuzz/src -I/usr/include/python3.10 -c harfbuzz/src/harfbuzz.cc -o build/temp.linux-x86_64-3.10/harfbuzz/src/harfbuzz.o -std=c++11
In file included from harfbuzz/src/hb-ot-face.cc:42,
                 from harfbuzz/src/harfbuzz.cc:17:
harfbuzz/src/hb-ot-layout-gsub-table.hh:32:10: fatal error: OT/Layout/GSUB/GSUB.hh: No such file or directory
   32 | #include "OT/Layout/GSUB/GSUB.hh"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~

Sure enough there is no GSUB.hh in the sources as distributed on PyPi, but it is referenced in the sources in harfbuzz/src/hb-ot-layout-gsub-table.hh.

khaledhosny commented 2 years ago

I don't know how dist is created, but I guess we need to update https://github.com/harfbuzz/uharfbuzz/blob/main/MANIFEST.in

alerque commented 2 years ago

That seems to have done the trick, thanks @khaledhosny and @anthrotype.