search

harishanchu / Laravel-FTP

A simple Laravel 4/5/6/7 ftp service provider with basic ftp methods.
220 stars 87 forks source link

Why not use Flysystem? #38

Closed emilv closed 8 years ago

emilv commented 8 years ago

Is there a reason to use this library instead of the built-in Flysystem in Laravel 5? I just added this to my disks in filesystems.php:

    'ftp' => [
        'driver' => 'ftp',
        'host' => '...',
        'port' => 21,
        'timeout' => 20,
        'username' => '...',
        'password' => '...',
        'passive' => true,
    ],

And now I can open, read and write files to my heart's content with Storage::disk('ftp')->... in the same way as any other filesystem!

Maybe this library is only needed for legacy reasons? Should that be added to the README?

harishanchu commented 8 years ago

I don't think you can connect to ftp in laravel 5 just with its file system feature.

If you meant by using this package: https://github.com/GrahamCampbell/Laravel-Flysystem , then I guess it's not built in.

emilv commented 8 years ago

You're wrong. Laravel ships with a dependency on Flysystem and the core league/flysystem package includes the FTP adapter. The Illuminate FilesystemManager handles it out of the box on a bare Laravel install since March 2015.

harishanchu commented 8 years ago

Yeah, your are right, but methods supported by flysystem adapter may vary from this library. Anyway need to add this to README.

Thanks