search

harjot-oberai / MusicDNA

A Music Player for android that renders beautiful DNA(Visualization) of the currently playing music.
Other
2.83k stars 582 forks source link

References #28 [Remove unused / unneeded Permission request] #29

Closed mrdjohnson closed 7 years ago

mrdjohnson commented 7 years ago

-Removed Microphone request -Did overall cleanup of class -Added functionality to also exit if MODIFY_AUDIO_SETTINGS is not permitted

mrdjohnson commented 7 years ago

Hmm, as far as I can tell this app does not need to make or manage phone calls either? Why is that requested?

kdexd commented 7 years ago

@DocJava The DNA is formed by real time sampling and FFT of song stream, hence the app needs to pause when there is an incoming call and resume when it is over.

mrdjohnson commented 7 years ago

Ooooh, neat! Understood. Did it need the microphone as well then?

kdexd commented 7 years ago

I'm not sure about that part, but logically it looks like a yes. @harjot-oberai your discretion is required.

harjot-oberai commented 7 years ago

Microphone is not used but the Visualizer class requires audio record permission for doing FFT calculations. Actually it just records a small snippet for calculations and then overwrites it. I am yet to review this PR locally. I will probably merge it tonight if everything checks out. 👍

harjot-oberai commented 7 years ago

Your code had a lot of issues, see the final code that I have merged into master. Initially I had written really shoddy code and your PR seemed to fix it, but it still had issues.

mrdjohnson commented 7 years ago

Besides not recording audio, what was wrong with the code? Just curious.