search

harjot-oberai / VectorMaster

Dynamic control over vector drawables!
MIT License
1.59k stars 161 forks source link

Update GroupModel.java #4

Closed negroelemental closed 6 years ago

negroelemental commented 6 years ago

Avoiding NnullPointerException when name of a GroupModel is null

harjot-oberai commented 6 years ago

Thanks for adding the check, it never crossed my mind . There are others methods like getPathModelByName and getClipPathModelByName that require a similar check. If you can add those, I'll merge the pull request.

Cheers.

unidaysgraham commented 6 years ago

Has this been merged? Are you open to receiving more PRs?

unidaysgraham commented 6 years ago

👏

harjot-oberai commented 6 years ago

I am closing this Pull Request due to inactivity. There were a few more methods that needed to be fixed the same way. I have now used the method suggested by @unidaysgraham , using Objects.equals(a,b), and fixed everything.

Thanks for your inputs and efforts @unidaysgraham and @negroelemental .

Cheers 🍻