search

harlan-zw / nuxt-site-config

Unifying site config with powerful and flexible APIs, for module authors and users.
https://nuxtseo.com/site-config
61 stars 3 forks source link

chore(types): cleanup #6

Closed dargmuesli closed 6 months ago

dargmuesli commented 9 months ago

Description

Just some opportunities to cleanup types that I came across while preparing my next PR.

Linked Issues

n/a

Additional context

Any reason for the repeated typesPath usage?

harlan-zw commented 9 months ago

IIRC the types will break on some setups when not imported like within the augmented module.

dargmuesli commented 9 months ago

Maybe we can add a comment linking the source of that circumstance? It's always nice to have the opportunity to learn from that :bulb:

harlan-zw commented 9 months ago

Maybe we can add a comment linking the source of that circumstance? It's always nice to have the opportunity to learn from that 💡

I was around 15 layers deep into stackoverflow before I found this solution so not sure I'll be able to find a reference :sweat_smile:

dargmuesli commented 9 months ago

Maybe it pops up. If not, you can close this PR :pray: