harlan-zw / unlighthouse

Scan your entire site with Google Lighthouse in 2 minutes (on average). Open source, fully configurable with minimal setup.

https://unlighthouse.dev

MIT License

3.65k stars 105 forks source link

chore: update lighthouse #183

Closed lutejka closed 4 months ago

lutejka commented 5 months ago

Description

Hey @harlan-zw this will update lighthouse to the current version. I already gave it a try in #167 but it did not play nice with jiti However, this time it seems to work fine for me. If it does not work for you, let me know, so I can investigate further.

Linked Issues

124

lutejka commented 5 months ago

The test is failing because the best-practice score is below the budget. [Unlighthouse] /blog/2023-may has invalid score0.74for categorybest-practices` I updated the budget, but the test still seem to use the old budget. Not sure to rerun them with the current budget

harlan-zw commented 4 months ago

Thanks, I'm guessing this may have some issues but will merge anyway and try to get this shipped :ship:

harlan-zw commented 4 months ago

Actually looks to be working pretty well! I think JITI finally solved their blocking issue with the CJS / MJS

lutejka commented 4 months ago

The trick is actually to add the .cjs extension to the import. This will tell node how to interpret the import...