search

harlan-zw / unlighthouse

Scan your entire site with Google Lighthouse in 2 minutes (on average). Open source, fully configurable with minimal setup.
https://unlighthouse.dev
MIT License
3.88k stars 115 forks source link

fix: show lighthouse runtime error when re-queuing failed routes #250

Closed adamkoppede closed 1 week ago

adamkoppede commented 1 week ago

For me, an absent NODE_EXTRA_CA_CERTS environment variable caused the lighthouse tasks to fail due to invalid TLS certificates after an upgrade in a containerized environment. In that case, the existing error message wasn't helpful, because the same URL worked fine on the host where the certificate was correctly installed and picked up.

netlify[bot] commented 1 week ago

Deploy request for unlighthouse-crux-api pending review.

Visit the deploys page to approve it

Name Link
Latest commit 05e92c8ed5f75a961af58ade89c87a8d6c048cb3
adamkoppede commented 1 week ago

I don't think my issue was related to #203, because there the route is eventually successful after some failed attempts. This wasn't the case for my TLS certificate mis-configuration. But this change may help anyways, if lighthouse sets the runtime error field there.

harlan-zw commented 1 week ago

Good idea, thanks! Will get a release out a bit later today most likely.