harlanhong / CVPR2022-DaGAN

Official code for CVPR2022 paper: Depth-Aware Generative Adversarial Network for Talking Head Video Generation
https://harlanhong.github.io/publications/dagan.html
Other
958 stars 125 forks source link

Fix some codes about py-feat library #25

Closed samsara-ku closed 2 years ago

samsara-ku commented 2 years ago

Hi @harlanhong !

First, I'm very pleased to see your works, DaGAN. Thanks for your effort. The reason why I issue this post is I just want to fix your code a little bit. In your utils.py, there are some codes using py-feat library and this a causes of problem. I don't know which version of py-feat you use, but no matter what you should change some codes like this way due to latest version using this way:

p1 = out1.facepose().values # AS-IS
p1 = out1.facepose.values # TO-BE

because latest version of py-feat uses facepose as property like this:

@property
    def facepose(self):
        """Returns the facepose data using the columns set in fex.facepose_columns

        Returns:
            DataFrame: facepose data
        """
        return self[self.facepose_columns]

Could you fix this problems for anybody who will use this codes?

harlanhong commented 2 years ago

Hi @samsara-ku

Thanks for your suggestion. I have merged the modification.

samsara-ku commented 2 years ago

Hi, @harlanhong

I'm sorry for bothering you, but could you please change this codes?

# AS-IS
gt_aus = out_gt.aus().values
generate_aus = out_generat.aus().values
# TO-BE
gt_aus = out_gt.aus.values
generate_aus = out_generat.aus.values

Because of poor English skills, I couldn't convey my intentions accurately.

harlanhong commented 2 years ago

Hi, @harlanhong

I'm sorry for bothering you, but could you please change this codes?

# AS-IS
gt_aus = out_gt.aus().values
generate_aus = out_generat.aus().values
# TO-BE
gt_aus = out_gt.aus.values
generate_aus = out_generat.aus.values

Because of poor English skills, I couldn't convey my intentions accurately.

Done! Thanks.